Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove reconnection feature from client library #849

Merged
merged 9 commits into from Feb 18, 2021

Conversation

yirutang
Copy link
Contributor

@yirutang yirutang commented Feb 17, 2021

Since there is major refactoring needed in order for this to work smoothly, temporarily remove this feature and let client retry connection. Also remove a flaky test FlushAllFailed, that feature is going to be removed in another PR.

@yirutang yirutang requested a review from as a code owner Feb 17, 2021
@yirutang yirutang requested a review from steffnay Feb 17, 2021
@product-auto-label product-auto-label bot added the api: bigquerystorage label Feb 17, 2021
@google-cla google-cla bot added the cla: yes label Feb 17, 2021
@codecov
Copy link

@codecov codecov bot commented Feb 18, 2021

Codecov Report

Merging #849 (d1bd3e0) into master (f26359c) will decrease coverage by 0.40%.
The diff coverage is 69.23%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #849      +/-   ##
============================================
- Coverage     81.14%   80.74%   -0.41%     
+ Complexity      996      990       -6     
============================================
  Files            74       74              
  Lines          5347     5317      -30     
  Branches        415      413       -2     
============================================
- Hits           4339     4293      -46     
- Misses          838      849      +11     
- Partials        170      175       +5     
Impacted Files Coverage Δ Complexity Δ
.../google/cloud/bigquery/storage/v1beta2/Waiter.java 55.05% <0.00%> (-17.89%) 14.00 <0.00> (-4.00)
...e/cloud/bigquery/storage/v1beta2/StreamWriter.java 84.11% <100.00%> (-0.92%) 36.00 <0.00> (-2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 687d48a...57426c4. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit 86dfc3a into googleapis:master Feb 18, 2021
16 checks passed
@yirutang yirutang deleted the remove-reconnect branch Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants