fix: remove reconnection feature from client library #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigquerystorage
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #849 +/- ##
============================================
- Coverage 81.14% 80.74% -0.41%
+ Complexity 996 990 -6
============================================
Files 74 74
Lines 5347 5317 -30
Branches 415 413 -2
============================================
- Hits 4339 4293 -46
- Misses 838 849 +11
- Partials 170 175 +5
Continue to review full report at Codecov.
|
yayi-google
reviewed
Feb 18, 2021
...ud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/StreamWriter.java
Outdated
Show resolved
Hide resolved
yayi-google
reviewed
Feb 18, 2021
...ud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/StreamWriter.java
Outdated
Show resolved
Hide resolved
yayi-google
reviewed
Feb 18, 2021
...ud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/StreamWriter.java
Outdated
Show resolved
Hide resolved
stephaniewang526
approved these changes
Feb 18, 2021
shubhwip
pushed a commit
to shubhwip/java-bigquerystorage
that referenced
this pull request
Oct 7, 2023
Fixes a NullPointerException introduced in googleapis#841 which occured when trying to check the the requesterPays status of a file while authenticated with an invalid service account. Refs: googleapis#849, googleapis#841
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there is major refactoring needed in order for this to work smoothly, temporarily remove this feature and let client retry connection. Also remove a flaky test FlushAllFailed, that feature is going to be removed in another PR.