Merge pull request #623 from sduskis/update_heapsize_test

Removing @VisibleForTesting from BigtableBufferedMutator.

bigtable-hbase/src/main/java/com/google/cloud/bigtable/hbase/BigtableBufferedMutator.java

@@ -39,7 +39,6 @@
 import com.google.cloud.bigtable.grpc.async.AsyncExecutor;
 import com.google.cloud.bigtable.grpc.async.HeapSizeManager;
 import com.google.cloud.bigtable.hbase.adapters.HBaseRequestAdapter;
-import com.google.common.annotations.VisibleForTesting;
 import com.google.common.util.concurrent.FutureCallback;
 import com.google.common.util.concurrent.Futures;
 import com.google.common.util.concurrent.ListenableFuture;
@@ -48,7 +47,6 @@
 /**
  * Bigtable's {@link BufferedMutator} implementation.
  */
-// TODO: Cleanup the interface so that @VisibleForTesting can be reduced.
 public class BigtableBufferedMutator implements BufferedMutator {
 
   protected static final Logger LOG = new Logger(BigtableBufferedMutator.class);
@@ -170,7 +168,7 @@ public void mutate(final Mutation mutation) throws IOException {
     }
   }
 
-  private void doMutation(final Mutation mutation) throws RetriesExhaustedWithDetailsException {
+  private void doMutation(final Mutation mutation) {
     Futures.addCallback(issueRequest(mutation), new ExceptionCallback(mutation));
   }
 
@@ -255,7 +253,6 @@ public void onSuccess(GeneratedMessage ignored) {
     }
   }
 
-  @VisibleForTesting
   public boolean hasInflightRequests() {
     return this.asyncExecutor.hasInflightRequests();
   }

bigtable-hbase/src/test/java/com/google/cloud/bigtable/hbase/TestBigtableBufferedMutator.java

@@ -98,7 +98,7 @@ public <T> FutureCallback<T> addCallback(ListenableFuture<T> future, Long id) {
   }
 
   @Test
-  public void testNoMutation() throws IOException {
+  public void testNoMutation() {
     Assert.assertFalse(underTest.hasInflightRequests());
   }