Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some guava classes are not repackaged (version 0.2.2) #605

Closed
yaitskov opened this issue Dec 19, 2015 · 3 comments
Closed

Some guava classes are not repackaged (version 0.2.2) #605

yaitskov opened this issue Dec 19, 2015 · 3 comments
Assignees
@sduskis
Labels
api: bigtable Issues related to the googleapis/java-bigtable-hbase API.

Comments

@yaitskov
Copy link

I use guava 18.0 and
it has com/google/thirdparty/publicsuffix/PublicSuffixPatterns.class

the client has different version which doesn't have EXACT public static field
which is used by other part of guava.
So I get NoSuchFieldException.
sduskis added a commit to sduskis/cloud-bigtable-client that referenced this issue Dec 22, 2015
@sduskis
Shading com.google.thirdparty.
9a5b299 
com.google.thirdparty is part of the guava jar that until now was
only partially renamed.  This was causing a user a problem in googleapis#605.
@sduskis sduskis mentioned this issue Dec 22, 2015
Merged
@sduskis
Copy link
Contributor

sduskis commented Dec 23, 2015

The PR with the change was merged. I also deployed a 0.2.3-SNAPSHOT with this change. We should have an official release early in the new year.

@sduskis sduskis closed this as completed Dec 23, 2015
@yaitskov
Copy link
Author

0.2.3 snapshot still has these classes. I don't understand what was changed otherwise.

https://oss.sonatype.org/content/repositories/snapshots/com/google/cloud/bigtable/bigtable-hbase-1.1/0.2.3-SNAPSHOT/bigtable-hbase-1.1-0.2.3-20151222.192823-12.jar

  drwxrwxrwx         0  18-Nov-2015  11:15:56  com/google/thirdparty/
  drwxrwxrwx         0  18-Nov-2015  11:15:56  com/google/thirdparty/publicsuffix/
  -rw-rw-rw-     46600  18-Nov-2015  11:15:56  com/google/thirdparty/publicsuffix/PublicSuffixPatterns.class
  -rw-rw-rw-      2437  18-Nov-2015  11:15:56  com/google/thirdparty/publicsuffix/PublicSuffixType.class
  -rw-rw-rw-      4266  18-Nov-2015  11:15:56  com/google/thirdparty/publicsuffix/TrieParser.class

@sduskis sduskis reopened this Dec 23, 2015
@sduskis
Copy link
Contributor

sduskis commented Dec 25, 2015

I redeployed. It looks better now.

@sduskis sduskis closed this as completed Dec 25, 2015
@google-cloud-label-sync google-cloud-label-sync bot added the api: bigtable Issues related to the googleapis/java-bigtable-hbase API. label Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sduskis sduskis

Labels
api: bigtable Issues related to the googleapis/java-bigtable-hbase API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sduskis @yaitskov