Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make AbstractCloudBigtableTableWriteFn public & rename #607

Closed
derjust opened this issue Dec 21, 2015 · 2 comments
Closed

Make AbstractCloudBigtableTableWriteFn public & rename #607

derjust opened this issue Dec 21, 2015 · 2 comments
Assignees
@sduskis
Labels
api: bigtable Issues related to the googleapis/java-bigtable-hbase API.

Comments

@derjust
Copy link
Contributor

derjust commented Dec 21, 2015

The class AbstractCloudBigtableTableWriteFn provides connection pool managment for situations that go beyond batch-read/writing.

Right now the class is package-private and has 'Write' in its name whereas the class has no writing-functionality.
It would be great to have this class public & generic named to be used as starting point for complex DoFns - like processing the output of a Scan while aggregating with additional data from Gets.
sduskis added a commit to sduskis/cloud-bigtable-client that referenced this issue Dec 22, 2015
@sduskis
Creating AbstractCloudBigtableTableDoFn for complex user CBT DoFns.
b50122b 
Multiple users contacted us about DoFns that require some additional Gets, including issue googleapis#607.  This PR should help.
@sduskis sduskis mentioned this issue Dec 22, 2015
Closed
sduskis added a commit to sduskis/cloud-bigtable-client that referenced this issue Dec 22, 2015
@sduskis
Addding AbstractCloudBigtableTableDoFn for complex user CBT DoFns.
ff6cc7c 
Multiple users contacted us about DoFns that require some additional Gets, including issue googleapis#607. This PR should help.
@sduskis sduskis mentioned this issue Dec 22, 2015
Merged
sduskis added a commit to sduskis/cloud-bigtable-client that referenced this issue Dec 22, 2015
@sduskis
Addding AbstractCloudBigtableTableDoFn for complex user CBT DoFns.
4497cd8 
Multiple users contacted us about DoFns that require some additional Gets, including issue googleapis#607. This PR should help.
@sduskis
Copy link
Contributor

sduskis commented Dec 22, 2015

Good suggestion. I merged this change, and will submit an 0.2.3-SNAPSHOT shortly.

@sduskis
Copy link
Contributor

sduskis commented Dec 22, 2015

I pushed a new SNAPSHOT. Closing the issue. Please reopen if need be.

@sduskis sduskis closed this as completed Dec 22, 2015
@sduskis sduskis self-assigned this Dec 22, 2015
@google-cloud-label-sync google-cloud-label-sync bot added the api: bigtable Issues related to the googleapis/java-bigtable-hbase API. label Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sduskis sduskis

Labels
api: bigtable Issues related to the googleapis/java-bigtable-hbase API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sduskis @derjust