Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add GRPC DatastoreTest and parameterize DatastoreTest for both gRPC and HTTP transports #1478

Merged
merged 4 commits into from
Jun 6, 2024

Conversation

cindy-peng
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️
Currently DatastoreTest is only using HTTP transports. This change is to add Grpc transports for datastore test and parameterize DatastoreTest to run for both gRPC and HTTP transports.

If you write sample code, please follow the samples format.

@cindy-peng cindy-peng requested review from a team as code owners June 4, 2024 09:18
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: datastore Issues related to the googleapis/java-datastore API. labels Jun 4, 2024
@cindy-peng cindy-peng changed the title Add GRPC DatastoreTest and parameterize DatastoreTest to run for both gRPC and HTTP transports test: Add GRPC DatastoreTest and parameterize DatastoreTest to run for both gRPC and HTTP transports Jun 4, 2024
@cindy-peng cindy-peng changed the title test: Add GRPC DatastoreTest and parameterize DatastoreTest to run for both gRPC and HTTP transports test: Add GRPC DatastoreTest and parameterize DatastoreTest for both gRPC and HTTP transports Jun 4, 2024
@cindy-peng cindy-peng requested a review from kolea2 June 4, 2024 10:30
Copy link

@gkevinzheng gkevinzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cindy-peng cindy-peng merged commit 2306cfa into grpc-experimental Jun 6, 2024
21 checks passed
@cindy-peng cindy-peng deleted the cindy-grpc-test branch June 6, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the googleapis/java-datastore API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants