Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: tweak Count API docs #1522

Merged
merged 2 commits into from
Jan 10, 2024
Merged

docs: tweak Count API docs #1522

merged 2 commits into from
Jan 10, 2024

Conversation

dconeybe
Copy link
Contributor

Apply the feedback to the count and aggregation API documentation as suggested in firebase/firebase-js-sdk#6608. This is a port of firebase/firebase-js-sdk#7933.

@dconeybe dconeybe self-assigned this Jan 10, 2024
Copy link

conventional-commit-lint-gcf bot commented Jan 10, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: firestore Issues related to the googleapis/java-firestore API. labels Jan 10, 2024
@dconeybe dconeybe changed the title Small Count API documentation improvements docs: tweak Count API docs Jan 10, 2024
@dconeybe dconeybe added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 10, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 10, 2024
@dconeybe dconeybe marked this pull request as ready for review January 10, 2024 19:31
@dconeybe dconeybe requested a review from a team as a code owner January 10, 2024 19:31
@dconeybe dconeybe added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 10, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 10, 2024
@dconeybe dconeybe merged commit e25ae13 into main Jan 10, 2024
23 checks passed
@dconeybe dconeybe deleted the dconeybe/CountApiDocTweaks branch January 10, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/java-firestore API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants