Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency com.google.cloud:google-cloud-firestore to v3.6.0 #1056

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Oct 5, 2022

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
com.google.cloud:google-cloud-firestore 3.5.0 -> 3.6.0 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, click this checkbox. ⚠ Warning: custom changes will be lost.

This PR has been generated by Mend Renovate. View repository job log here.

@renovate-bot renovate-bot requested review from a team as code owners October 5, 2022 17:08
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 5, 2022
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/java-firestore API. label Oct 5, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 5, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 5, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 5, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 5, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 5, 2022
@tom-andersen tom-andersen added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 5, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 5, 2022
@lqiu96 lqiu96 added automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement. labels Oct 6, 2022
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 6, 2022
@lqiu96 lqiu96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 6, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 6, 2022
@lqiu96 lqiu96 added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Oct 6, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 6, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit f7dfdd1 into googleapis:main Oct 6, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 6, 2022
@dconeybe
Copy link
Contributor

FYI: This PR has broken the samples github action:

[ERROR] com.example.firestore.beam.ExampleFirestoreWriteReadTest  Time elapsed: 0.927 s  <<< ERROR!
java.lang.NoClassDefFoundError: io/grpc/InternalMayRequireSpecificExecutor

e.g. https://source.cloud.google.com/results/invocations/7e2873e9-3315-4cc2-8adf-7ff069149ad8/targets

@lqiu96
Copy link
Contributor

lqiu96 commented Oct 13, 2022

java.lang.NoClassDefFoundError: io/grpc/InternalMayRequireSpecificExecutor

Couldn't figure out where this was coming from. It's from grpc-java added in this commit: grpc/grpc-java@c27f2d5 and released in v1.50.0. The grpc-java release was done two days ago, but the GH Action in this PR was run 7 days ago. This PR for shared-deps also has this failure and was run 10 days ago: #1053.

The latest gax-java release has io.grpc v1.49.2: https://github.com/googleapis/gax-java/blob/870c732f48d963fe6be837a9d5247e7593a32d27/dependencies.properties#L28

I'm a bit lost as to what is happening. I don't think there were any code changes in the samples. Seems to fail in the setup() of the test -- taking another look.

@lqiu96
Copy link
Contributor

lqiu96 commented Oct 13, 2022

Earliest fusion logs that we're able to see (~30 days) seem to show this error stemming from #1053. Only change that seems relevant is the grpc version bump (googleapis/java-shared-dependencies@v3.0.3...v3.0.4) to v1.49.2

@dconeybe
Copy link
Contributor

Huh you're right. Sorry, I may have found an incorrect culprit PR. My colleague dug into it a bit and found that the problematic class, InternalMayRequireSpecificExecutor was added in 1.49.2. Running mvn dependency:tree in the samples directory shows that there are still some deps that pull in 1.49.0. I'm not familiar enough with maven to know how it resolves these discrepancies.

@lqiu96
Copy link
Contributor

lqiu96 commented Oct 13, 2022

I think the problematic class was released in v1.50.0 (not v.1.49.2): grpc/grpc-java@v1.49.2...v1.50.0

This is the commit:
image

Generally we have a shared-dependencies bom (https://github.com/googleapis/java-shared-dependencies/) that declares these dependencies and the corresponding versions. This is relevant GRPC-BOM: (https://github.com/googleapis/java-shared-dependencies/blob/99aa55158a3a1094aa33cc69bedfba9b0a6fb2d7/first-party-dependencies/pom.xml#L77) that declares the versions for the grpc-* libraries.

For presubmit checks, the build.sh file looks for the pom.xml in the snapshot/ directory and runs only those tests

SAMPLES_DIR=samples/snapshot
. The snapshot pom.xml pulls in firestore v3.6.0 which has v3.0.4 of shared-dependences (and v1.49.2 of GRPC-*).

Everything seems to check out "version-wise" except (I believe) it's using classes from v1.50.0 of grpc-java.

I could be missing something completely obvious...

@diegomarquezp
Copy link
Contributor

diegomarquezp commented Oct 20, 2022

InternalMayRequireSpecificExecutor is actually available in 1.49.2. Running mvn dependency:tree -Dverbose in samples/snapshot produces (check edit):

[INFO] |  +- io.grpc:grpc-core:jar:1.43.2:compile
...
[INFO] |  +- io.grpc:grpc-googleapis:jar:1.49.2:runtime

(grpc-googleapis:1.49.2 depends on grpc-core:1.49.2)

It looks like this is causing a mismatch between expected classes at compile time and runtime.
I'm still yet to determine what makes maven to resolve to the outdated 1.43.2 version of grpc-core.

Edit: -Dverbose may produce incorrect output according to this - without the option it shows grpc-core:1.48.0:compile, without runtime version specified (which I'm currently looking for)

@lqiu96
Copy link
Contributor

lqiu96 commented Oct 24, 2022

InternalMayRequireSpecificExecutor is actually available in 1.49.2.

Ah yeah looks like it was released in v1.49.2. Looks like there might have been some issue with the branch versions, but the tags do show it in v1.49.2.

I ran mvn dependency:tree without the -Dverbose flag (thanks to the link you sent about incorrect output). Will take another look.

Running mvn dependency:tree -Dincludes=io.grpc:grpc-api gives me this:

[INFO] com.google.cloud:firestore-snapshot:jar:1.2.0
[INFO] \- org.apache.beam:beam-runners-google-cloud-dataflow-java:jar:2.42.0:compile
[INFO]    \- org.apache.beam:beam-sdks-java-io-google-cloud-platform:jar:2.42.0:compile
[INFO]       \- io.grpc:grpc-api:jar:1.48.0:compile

I'm going to try and exclude them from the beam library in a separate PR to see if that resolves the issue.

cherylEnkidu pushed a commit that referenced this pull request Dec 11, 2023
…e to v3.6.0 (#1056)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-firestore](https://togithub.com/googleapis/java-firestore) | `3.5.0` -> `3.6.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-firestore/3.6.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-firestore/3.6.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-firestore/3.6.0/compatibility-slim/3.5.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-firestore/3.6.0/confidence-slim/3.5.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-firestore).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMTcuMCIsInVwZGF0ZWRJblZlciI6IjMyLjIxNy4wIn0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/java-firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants