-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency com.google.cloud:google-cloud-firestore to v3.6.0 #1056
chore(deps): update dependency com.google.cloud:google-cloud-firestore to v3.6.0 #1056
Conversation
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
FYI: This PR has broken the samples github action:
e.g. https://source.cloud.google.com/results/invocations/7e2873e9-3315-4cc2-8adf-7ff069149ad8/targets |
Couldn't figure out where this was coming from. It's from grpc-java added in this commit: grpc/grpc-java@c27f2d5 and released in v1.50.0. The grpc-java release was done two days ago, but the GH Action in this PR was run 7 days ago. This PR for shared-deps also has this failure and was run 10 days ago: #1053. The latest gax-java release has io.grpc v1.49.2: https://github.com/googleapis/gax-java/blob/870c732f48d963fe6be837a9d5247e7593a32d27/dependencies.properties#L28 I'm a bit lost as to what is happening. I don't think there were any code changes in the samples. Seems to fail in the setup() of the test -- taking another look. |
Earliest fusion logs that we're able to see (~30 days) seem to show this error stemming from #1053. Only change that seems relevant is the grpc version bump (googleapis/java-shared-dependencies@v3.0.3...v3.0.4) to v1.49.2 |
Huh you're right. Sorry, I may have found an incorrect culprit PR. My colleague dug into it a bit and found that the problematic class, |
I think the problematic class was released in v1.50.0 (not v.1.49.2): grpc/grpc-java@v1.49.2...v1.50.0 This is the commit:
|
SAMPLES_DIR=samples/snapshot |
Everything seems to check out "version-wise" except (I believe) it's using classes from v1.50.0 of grpc-java.
I could be missing something completely obvious...
( It looks like this is causing a mismatch between expected classes at compile time and runtime. Edit: |
Ah yeah looks like it was released in v1.49.2. Looks like there might have been some issue with the branch versions, but the tags do show it in v1.49.2. I ran Running
I'm going to try and exclude them from the beam library in a separate PR to see if that resolves the issue. |
…e to v3.6.0 (#1056) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-firestore](https://togithub.com/googleapis/java-firestore) | `3.5.0` -> `3.6.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-firestore/3.6.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-firestore/3.6.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-firestore/3.6.0/compatibility-slim/3.5.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-firestore/3.6.0/confidence-slim/3.5.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-firestore). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMTcuMCIsInVwZGF0ZWRJblZlciI6IjMyLjIxNy4wIn0=-->
This PR contains the following updates:
3.5.0
->3.6.0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Mend Renovate. View repository job log here.