Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(sample): Use Java 8 for native image sample #893

Merged
merged 5 commits into from
Mar 1, 2022
Merged

docs(sample): Use Java 8 for native image sample #893

merged 5 commits into from
Mar 1, 2022

Conversation

mpeddada1
Copy link
Contributor

This should fix the Native Image sample which is failing with the following error:

Screen Shot 2022-03-01 at 5 02 36 PM

@mpeddada1 mpeddada1 requested review from a team as code owners March 1, 2022 22:03
@product-auto-label product-auto-label bot added api: firestore Issues related to the googleapis/java-firestore API. samples Issues that are directly related to samples. labels Mar 1, 2022
suztomo
suztomo approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also fix

              <mainClass>com.example.firestore.NativeImageFirestoreSample
              </mainClass>

to

              <mainClass>com.example.firestore.NativeImageFirestoreSample</mainClass>

@suztomo suztomo changed the title fix(java): Use Java 8 for native image sample docs(sample): Use Java 8 for native image sample Mar 1, 2022
@suztomo
Copy link
Member

suztomo commented Mar 1, 2022 •
edited
Loading

I updated the title to reflect that the fix is not for the library users.

@mpeddada1 mpeddada1 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 1, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 1, 2022
@mpeddada1 mpeddada1 merged commit 5955f54 into main Mar 1, 2022
@mpeddada1 mpeddada1 deleted the fix-native-sample branch March 1, 2022 23:39
@release-please release-please bot mentioned this pull request Mar 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neenu1995 Neenu1995 Neenu1995 approved these changes

@suztomo suztomo suztomo approved these changes

@meltsufin meltsufin Awaiting requested review from meltsufin

Assignees

@eaball35 eaball35

Labels
api: firestore Issues related to the googleapis/java-firestore API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mpeddada1 @suztomo @Neenu1995 @yoshi-kokoro @eaball35