Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid blocking alarm pool during stream reconnects #1400

Merged
merged 2 commits into from
May 15, 2023

Conversation

tmdiep
Copy link
Collaborator

@tmdiep tmdiep commented May 13, 2023

Do not process background requests in alarm pool while publish and subscribe streams are reconnecting. Avoid grabbing the same lock as reinitialize, which will be held until the stream is successfully reconnected.

Also reverts #1394, which can cause thread explosion.

Do not process background requests in alarm pool while publish and subscribe streams are reconnecting. Avoid grabbing the same lock as reinitialize, which will be held until the stream is successfully reconnected.

Also reverts googleapis#1394, which can cause thread explosion.
@tmdiep tmdiep requested a review from a team as a code owner May 13, 2023 23:16
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: pubsublite Issues related to the googleapis/java-pubsublite API. labels May 13, 2023
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels May 13, 2023
@tmdiep tmdiep added the owlbot:run Add this label to trigger the Owlbot post processor. label May 13, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 13, 2023
@dpcollins-google dpcollins-google merged commit 3197cc0 into googleapis:main May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants