-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use sdk-platform-java-config in downstream checks for spanner and pubsub; update junit-vintage to 5.10.2 #746
Conversation
.kokoro/client-library-check.sh
Outdated
setns x=http://maven.apache.org/POM/4.0.0 | ||
cd .//x:artifactId[text()="google-cloud-shared-config"] | ||
cd ../x:version | ||
set ${JAVA_SHARED_CONFIG_VERSION} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: from a generic, function design standpoint... using parameters should be preferred over using global state, as it makes the contract of the function when seeing it in use explicit rather than implicit.
In other words:
replace_java_shared_config_version pom.xml 2.3.4 # I can read this an know exactly what is happening.
vs
replace_java_shared_config_version # I don't know what this affects w/o going to read the function
See also "pure functions" and their many benefits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I've refactored this to accept args instead of using global variables.
For java-spanner, java-pubsub dependencies dw check:
Additional fix to address Graalvm downstream check failure:
The downstream GraalVM checks have been failing with:
This error occurs starting with native-maven-plugin:0.9.24 which introduced some changes to be compatible with junit:5.10.0 (graalvm/native-build-tools#472).
This PR updates the junit-vintage-engine to the latest version.