You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.
@KiranmayiB can you explain how does this change solve the issue we are seeing? @thiagotnunes
Here, the code puts a value into the measureMap twice and says record twice. That is causing the crash as we cannot put anything into the measureMap after we say record. So i think the second time when it tried to put a value after the record, it could not internally find the bucket causing an NPE. This is what i gathered from the bug.
@KiranmayiB is there any (manual) testing we can do for this (to simulate the bug and have the fix correct it)?
@thiagotnunes I dont know how to. Locally running a module dependent on this is looking okay. It worked fine the last time too. I don't know how to simulate the bug yet. I will follow-up on the bug.
@thiagotnunes: We shared the jar with the changes in this PR with the end user, and they confirmed that they're not facing the issue anymore. They're waiting for an official release to be available to use it. I think we can merge this PR.
api: spannerIssues related to the googleapis/java-spanner API.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
product-auto-label
bot
added
the
api: spanner
KiranmayiB
changed the title
rajatbhatta
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
thiagotnunes
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.