Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic dialect detection returns DEADLINE_EXCEEDED if session creation fails #1759

Closed
olavloite opened this issue Mar 19, 2022 · 0 comments · Fixed by #1760 or #1756
Closed

Automatic dialect detection returns DEADLINE_EXCEEDED if session creation fails #1759

olavloite opened this issue Mar 19, 2022 · 0 comments · Fixed by #1760 or #1756
Assignees
@olavloite
Labels
api: spanner Issues related to the googleapis/java-spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@olavloite
Copy link
Collaborator

The automatic dialect detection will return a DEADLINE_EXCEEDED error if the session pool failed to create any sessions. This for example happens if the user has requested a DatabaseClient for a database that does not exist, or that the user is not permitted to see. This is caused by the fact that the automatic dialect detection query is never triggered, as there is never any sessions being added to the pool.
@olavloite olavloite added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Mar 19, 2022
@olavloite olavloite self-assigned this Mar 19, 2022
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Mar 19, 2022
olavloite added a commit that referenced this issue Mar 19, 2022
@olavloite
fix: return errors from BatchCreateSession to dialect detection
52e0b2e 
Any error that was returned by BatchCreateSessions should also be set as
the result of the auto-detect dialect query, as the query will never be
able to return a result for the dialect when session creation fails.

Fixes #1759
@olavloite olavloite mentioned this issue Mar 19, 2022
Merged
olavloite added a commit that referenced this issue Mar 24, 2022
@olavloite
fix: return errors from BatchCreateSession to dialect detection (#1760)
6550a9d 
Any error that was returned by BatchCreateSessions should also be set as
the result of the auto-detect dialect query, as the query will never be
able to return a result for the dialect when session creation fails.

Fixes #1759
@release-please release-please bot mentioned this issue Mar 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olavloite olavloite

Labels
api: spanner Issues related to the googleapis/java-spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
1 participant
@olavloite