Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove the statement of session number limits #1928

Merged
merged 6 commits into from
Nov 18, 2022
Merged

fix: remove the statement of session number limits #1928

merged 6 commits into from
Nov 18, 2022

Conversation

rbrtwng
Copy link
Contributor

@rbrtwng rbrtwng commented Jun 24, 2022

Cloud Spanner no longer has the 10K "Sessions per database per node" limit.

Doc fix only

Fixes #1927

@rbrtwng
Remove the statement of session number limits
967d3d0 
Cloud Spanner no longer has the 10K "Sessions per database per node" limit.
@rbrtwng rbrtwng requested a review from a team as a code owner June 24, 2022 15:15
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/java-spanner API. labels Jun 24, 2022
@rbrtwng rbrtwng changed the title Remove the statement of session number limits fix: Remove the statement of session number limits Jun 24, 2022
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Jun 24, 2022 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@rahul2393 rahul2393 changed the title fix: Remove the statement of session number limits fix: remove the statement of session number limits Jun 27, 2022
ansh0l
ansh0l approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@ansh0l ansh0l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ansh0l
Copy link
Contributor

ansh0l commented Jul 4, 2022

(will wait for presubmits to run, since this is a doc string fix, adding automerge label)

@ansh0l
Copy link
Contributor

ansh0l commented Jul 4, 2022

@rbrtwng : It looks like a couple of (required) presubmits fail because of minor nits.

  1. Linting line 34 seems to have an additional whitespace at end
  2. Conventional commits: since commit message and PR subject have different title.

Please add them and tag me, I will run the presubmits again after them.

@rbrtwng
Copy link
Contributor Author

rbrtwng commented Jul 24, 2022

@ansh0l can you please run presubmit again?

@rajatbhatta rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 24, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 24, 2022
ansh0l
ansh0l approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@ansh0l ansh0l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but need to make a minor change to satisfy the lint presubmit.

google-cloud-spanner/src/main/java/com/google/cloud/spanner/Session.java Outdated
* <p>It is a good idea to delete idle and/or unneeded sessions. Aside from explicit deletes,
* Cloud Spanner can delete sessions for which no operations are sent for more than an hour,
* or due to internal errors. If a session is deleted, requests to it return
* {@link ErrorCode#NOT_FOUND}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rbrtwng : Please remove the whitespace at the end of this line, its failing one of the required presubmits for linting.

@ansh0l ansh0l added the automerge Merge the pull request once unit tests and other checks pass. label Aug 3, 2022
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 3, 2022
@ansh0l ansh0l added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 29, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 29, 2022
@rajatbhatta rajatbhatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 12, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 12, 2022
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner October 12, 2022 05:50
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Oct 12, 2022
@rajatbhatta rajatbhatta added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 12, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 12, 2022
@rajatbhatta rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 12, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 12, 2022
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 12, 2022
@ansh0l ansh0l added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 26, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 26, 2022
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Nov 17, 2022
@rajatbhatta rajatbhatta added the automerge Merge the pull request once unit tests and other checks pass. label Nov 17, 2022
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 17, 2022
@rajatbhatta rajatbhatta added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 17, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 17, 2022
@rajatbhatta rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 17, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 17, 2022
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Nov 17, 2022
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 17, 2022
@rajatbhatta rajatbhatta added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Nov 18, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 18, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit ddd0625 into googleapis:main Nov 18, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 18, 2022
@release-please release-please bot mentioned this pull request Nov 18, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Dec 13, 2022
@release-please
chore(main): release 6.34.0 (#2169)
6c3e3cc 
🤖 I have created a release *beep* *boop*
---


## [6.34.0](https://togithub.com/googleapis/java-spanner/compare/v6.33.0...v6.34.0) (2022-12-12)


### Features

* Setting up 6.33.x branch ([#2184](https://togithub.com/googleapis/java-spanner/issues/2184)) ([e237a21](https://togithub.com/googleapis/java-spanner/commit/e237a213cf5cb5edc338ca4e5f8ad5dd0593d2d1))


### Bug Fixes

* Remove the statement of session number limits ([#1928](https://togithub.com/googleapis/java-spanner/issues/1928)) ([ddd0625](https://togithub.com/googleapis/java-spanner/commit/ddd062527674659ca2ea73e079bca4dee62ca67f)), closes [#1927](https://togithub.com/googleapis/java-spanner/issues/1927)
* Update samples/snippets pom.xml configuration to avoid fat jar ([#2100](https://togithub.com/googleapis/java-spanner/issues/2100)) ([19058b4](https://togithub.com/googleapis/java-spanner/commit/19058b4cd324ce33e8dd52447bde2486c87d4754))
* Use a proper endpoint for DirectPath tests ([#2186](https://togithub.com/googleapis/java-spanner/issues/2186)) ([4d74a0d](https://togithub.com/googleapis/java-spanner/commit/4d74a0d8ae48e190c126ab4047b81cca117f4de1))


### Dependencies

* Update dependency org.graalvm.buildtools:junit-platform-native to v0.9.18 ([#2171](https://togithub.com/googleapis/java-spanner/issues/2171)) ([f348780](https://togithub.com/googleapis/java-spanner/commit/f3487805fe5f976596e94047c3796bc623eeae95))
* Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.18 ([#2145](https://togithub.com/googleapis/java-spanner/issues/2145)) ([dcdd2c3](https://togithub.com/googleapis/java-spanner/commit/dcdd2c3b684e38892fac0abbdf06081e9c7d83b2))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansh0l ansh0l ansh0l approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spanner: Doc Bug Cloud Spanner no longer has the 10K "Sessions per database per node" limit.
4 participants
@rbrtwng @ansh0l @yoshi-kokoro @rajatbhatta