Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-adds test-jar to bom definition #1596

Merged
merged 3 commits into from Dec 17, 2021
Merged

Conversation

thiagotnunes
Copy link
Contributor

@thiagotnunes thiagotnunes commented Dec 16, 2021

The test jar was wrongly removed during the owlbot migration.

google-cloud-spanner-bom has been added to an exclude list for owlbot. This means owlbot will not add new dependencies to the bom when a new version is introduced. Renovate bot will still update the versions and no other owlbot feature changes.

The test jar was wrongly removed during the owlbot migration.
@thiagotnunes thiagotnunes requested review from as code owners Dec 16, 2021
@product-auto-label product-auto-label bot added the api: spanner label Dec 16, 2021
@thiagotnunes
Copy link
Contributor Author

@thiagotnunes thiagotnunes commented Dec 16, 2021

It seems OwlBot is removing the dependency

@Neenu1995 Neenu1995 added the owlbot:run label Dec 16, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Dec 16, 2021
@Neenu1995 Neenu1995 added the kokoro:force-run label Dec 16, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Dec 16, 2021
@thiagotnunes thiagotnunes merged commit 5accdcd into main Dec 17, 2021
20 checks passed
@thiagotnunes thiagotnunes deleted the re-adds-test-jar-to-bom branch Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants