fix: surface storage interface expectations correctly. (#241)

* fix: add @InternalExtensionOnly * fix: correct README.md
googleapis · Apr 14, 2020 · 130a641 · 130a641
1 parent b5208b8
commit 130a641
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/README.md b/README.md
@@ -216,7 +216,8 @@ See [TESTING] to read more about testing.
 Versioning
 ----------
 
-This library follows [Semantic Versioning](http://semver.org/).
+This library follows [Semantic Versioning](http://semver.org/), but does update [Storage interface](src/main/java/com.google.cloud.storage/Storage.java)
+to introduce new methods which can break your implementations if you implement this interface for testing purposes.
 
 It is currently in major version one (``1.y.z``), which means that the public API should be considered stable.
 

diff --git a/google-cloud-storage/src/main/java/com/google/cloud/storage/Storage.java b/google-cloud-storage/src/main/java/com/google/cloud/storage/Storage.java
@@ -19,6 +19,7 @@
 import static com.google.common.base.Preconditions.checkArgument;
 import static com.google.common.base.Preconditions.checkNotNull;
 
+import com.google.api.core.InternalExtensionOnly;
 import com.google.api.gax.paging.Page;
 import com.google.auth.ServiceAccountSigner;
 import com.google.auth.ServiceAccountSigner.SigningException;
@@ -55,6 +56,7 @@
  *
  * @see <a href="https://cloud.google.com/storage/docs">Google Cloud Storage</a>
  */
+@InternalExtensionOnly
 public interface Storage extends Service<StorageOptions> {
 
   enum PredefinedAcl {