Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: implementations of FromHexString() for md5 and crc32c #246

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

frankyn
Copy link
Member

@frankyn frankyn commented Apr 14, 2020

FromHexString() helpers don't handle leading zeros correctly. Added tests and provided a new implementation.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 14, 2020
@frankyn frankyn added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 14, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 14, 2020
@codecov
Copy link

codecov bot commented Apr 14, 2020

Codecov Report

Merging #246 into master will increase coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #246      +/-   ##
============================================
+ Coverage     63.50%   63.52%   +0.02%     
  Complexity      540      540              
============================================
  Files            30       30              
  Lines          4762     4776      +14     
  Branches        427      431       +4     
============================================
+ Hits           3024     3034      +10     
- Misses         1578     1580       +2     
- Partials        160      162       +2     
Impacted Files Coverage Δ Complexity Δ
...c/main/java/com/google/cloud/storage/BlobInfo.java 88.25% <66.66%> (-0.71%) 88.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15cb267...b11e66c. Read the comment docs.

@frankyn frankyn merged commit c9b23b3 into master Apr 14, 2020
@frankyn frankyn deleted the fix-to-hex branch April 14, 2020 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants