Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add mypy function type check #134

Merged
merged 12 commits into from
May 20, 2024
Merged

ci: Add mypy function type check #134

merged 12 commits into from
May 20, 2024

Conversation

duwenxin99
Copy link
Contributor

Disallow incomplete or missing function types

@duwenxin99 duwenxin99 requested review from a team as code owners May 20, 2024 15:12
@product-auto-label product-auto-label bot added the api: alloydb Issues related to the googleapis/langchain-google-alloydb-pg-python API. label May 20, 2024
@duwenxin99 duwenxin99 changed the title ci: Add mypy disallow untyped function ci: Add mypy function type check May 20, 2024
@averikitsch
Copy link
Collaborator

Thank you for also fixing the issues found by the linter. For the other integrations we should have the teams work on fixing the issues.

@averikitsch averikitsch merged commit 704f593 into main May 20, 2024
12 checks passed
@averikitsch averikitsch deleted the mypy branch May 20, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: alloydb Issues related to the googleapis/langchain-google-alloydb-pg-python API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants