This repository has been archived by the owner on Sep 27, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 54
Added custom dictionary and regex code samples #204
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Dec 10, 2018
JustinBeckwith
approved these changes
Dec 11, 2018
JustinBeckwith
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Dec 11, 2018
kokoro-team
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Dec 11, 2018
JustinBeckwith
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Dec 11, 2018
kokoro-team
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Dec 11, 2018
When will this get merged into the main project? Is there some reason the checks aren't running? |
JustinBeckwith
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Dec 20, 2018
kokoro-team
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Dec 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DLP team is in the process of expanding code samples to include features that we have launched since the initial samples were written.
In this pull request, I updated inspect.js to include dictionary and regex based custom info types, and added some tests in inspect.test.js.