Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: modernize the sample tests #237

Merged
merged 1 commit into from
Dec 17, 2018
Merged

refactor: modernize the sample tests #237

merged 1 commit into from
Dec 17, 2018

Conversation

JustinBeckwith
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 16, 2018
@JustinBeckwith JustinBeckwith requested review from ofrobots and a team December 16, 2018 12:30
@JustinBeckwith JustinBeckwith mentioned this pull request Dec 16, 2018
Closed
1 task
kjin
kjin reviewed Dec 17, 2018
View reviewed changes
samples/system-test/express.test.js

before(tools.checkCredentials);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@JustinBeckwith JustinBeckwith merged commit 4e3f108 into googleapis:master Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjin kjin kjin left review comments

@ofrobots ofrobots ofrobots approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JustinBeckwith @ofrobots @kjin @googlebot