Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use originalUrl for Express middleware's request url #476

Merged
merged 6 commits into from
May 14, 2019

Conversation

hgiasac
Copy link
Contributor

@hgiasac hgiasac commented May 9, 2019

Use req.originalUrl instead of req.url to get full path (#472 )

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label May 9, 2019
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels May 11, 2019
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me, thanks for the contribution @hgiasac 👍

@bcoe
Copy link
Contributor

bcoe commented May 14, 2019

@ofrobots is this looking reasonable to you? seems like a good fix.

@bcoe bcoe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 14, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 14, 2019
@codecov
Copy link

codecov bot commented May 14, 2019

Codecov Report

Merging #476 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #476   +/-   ##
=======================================
  Coverage   97.21%   97.21%           
=======================================
  Files          10       10           
  Lines         431      431           
  Branches       55       55           
=======================================
  Hits          419      419           
  Partials       12       12
Impacted Files Coverage Δ
src/middleware/express/make-http-request.ts 100% <ø> (ø) ⬆️
src/middleware/express/make-middleware.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afe89de...af3fc43. Read the comment docs.

@bcoe bcoe requested a review from ofrobots May 14, 2019 22:25
export function makeHttpRequestData(
req: http.IncomingMessage,
req: ServerRequest,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strictly speaking this change is breaking for existing typescript users. However, given that the middleware is marked experimental, this is okay to ship as a non-major.

@ofrobots ofrobots merged commit 0ee71bd into googleapis:master May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants