-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use originalUrl for Express middleware's request url #476
use originalUrl for Express middleware's request url #476
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable to me, thanks for the contribution @hgiasac 👍
@ofrobots is this looking reasonable to you? seems like a good fix. |
Codecov Report
@@ Coverage Diff @@
## master #476 +/- ##
=======================================
Coverage 97.21% 97.21%
=======================================
Files 10 10
Lines 431 431
Branches 55 55
=======================================
Hits 419 419
Partials 12 12
Continue to review full report at Codecov.
|
export function makeHttpRequestData( | ||
req: http.IncomingMessage, | ||
req: ServerRequest, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strictly speaking this change is breaking for existing typescript users. However, given that the middleware is marked experimental, this is okay to ship as a non-major.
Use
req.originalUrl
instead ofreq.url
to get full path (#472 )