feat: accept entry.timestamp string input in RFC3339 format #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xSage
added
the
priority: p2
product-auto-label
bot
added
the
api: logging
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #937 +/- ##
=======================================
Coverage 98.21% 98.21%
=======================================
Files 18 18
Lines 10928 10940 +12
Branches 367 372 +5
=======================================
+ Hits 10733 10745 +12
Misses 193 193
Partials 2 2
Continue to review full report at Codecov.
|
JustinBeckwith
approved these changes
Nov 7, 2020
src/entry.ts
Outdated
| const nanoSecs = zuluTime.match(reNano)?.[1]; | ||
| entry.timestamp = { | ||
| seconds: ms ? Math.floor(ms / 1000) : 0, | ||
| nanos: nanoSecs ? parseInt(nanoSecs.padEnd(9, '0')) : 0, |
There was a problem hiding this comment.
It's generally safer to use the Number constructor instead of parseInt. parseInt is more liberal in what it accepts, and in some cases can make assumptions about the radix (leading 0s and octal numbers, etc).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #934
Context: