Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove test that depended on protobufjs error, now protobufjs correctly fails not finding the import #483

Merged
merged 7 commits into from
Feb 21, 2024
Merged

chore: remove test that depended on protobufjs error, now protobufjs correctly fails not finding the import #483

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b4737c9
chore: update package.json
sofisl Feb 16, 2024
118a9ad
Update package.json
sofisl Feb 16, 2024
4a96756
run tests
sofisl Feb 20, 2024
3ec6123
Update package.json
sofisl Feb 20, 2024
2ce6082
test: remove test relying on broken behavior in protobufjs
sofisl Feb 20, 2024
d556e27
emerge
sofisl Feb 20, 2024
f141732
Update package.json
sofisl Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 0 additions & 5 deletions test/load.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,6 @@ describe('loadSync', () => {
'../../test/fixtures',
'library.proto'
);
it('should not be able to load test file using protobufjs directly', () => {
const root = protobuf.loadSync(TEST_FILE);
// Common proto that should not have been loaded.
assert.strictEqual(root.lookup('google.api.Http'), null);
});

it('should load a test file that relies on common protos', () => {
const root = googleProtoFiles.loadSync(TEST_FILE);
Expand Down