Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from grpc to @grpc/grpc-js #627

Closed
merlinnot opened this issue May 24, 2019 · 2 comments · Fixed by #658
Closed

Switch from grpc to @grpc/grpc-js #627

merlinnot opened this issue May 24, 2019 · 2 comments · Fixed by #658
Assignees
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@merlinnot
Copy link
Contributor

Is your feature request related to a problem? Please describe.

@grpc/grpc-js has multiple advantages over grpc. All Google libraries are now switching to @grpc/grpc-js. This is the only library left that I still see a dependency on grpc, which is use only in tests and as a source of type definitions.

Describe the solution you'd like

I'd like to see the dependency dropped and the source code to either use type definitions from google-gax or @grpc/grpc-js.

Describe alternatives you've considered

I don't see alternatives.

Additional context

Not applicable.

@sduskis sduskis added the type: process A process-related concern. May include testing, release, or the like. label May 24, 2019
@sduskis
Copy link

sduskis commented May 24, 2019

Thanks for raising this issue. We used it at one point, and then reverted in #595. I'll follow up with @alexander-fenster and @bcoe to figure out timing of using grpc-js once again.

@sduskis sduskis added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triaged for GA type: process A process-related concern. May include testing, release, or the like. labels Jun 7, 2019
@sduskis
Copy link

sduskis commented Jun 13, 2019

@callmehiphop, would you be able to test out grpc-js with large messages (i.e. publish a 9MB message, and then subscribe and see the value)? If that works, then I think we can proceed with this. Otherwise, I think we need to create a bug for the grpc team.

@google-cloud-label-sync google-cloud-label-sync bot added the api: pubsub Issues related to the googleapis/nodejs-pubsub API. label Jan 31, 2020
feywind pushed a commit to feywind/nodejs-pubsub that referenced this issue Nov 12, 2024
* chore: update jsdoc - protos and double quote

* chore: update jsdoc - protos and double quote
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants