fix: update minimum gax version to 2.7.0 to fix recent protobuf errors #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and commit those changes
google-cla
bot
added
the
cla: yes
|
Pulling in @alexander-fenster to make sure this makes sense. |
Codecov Report
@@ Coverage Diff @@
## master #1085 +/- ##
=======================================
Coverage 97.78% 97.78%
=======================================
Files 25 25
Lines 11067 11067
Branches 546 575 +29
=======================================
Hits 10822 10822
Misses 241 241
Partials 4 4 Continue to review full report at Codecov.
|
bcoe
approved these changes
Aug 11, 2020
bcoe
approved these changes
Aug 11, 2020
There was a problem hiding this comment.
This seems right to me, I agree that getting @alexander-fenster's feedback would be good, let's not break folks twice.
skuruppu
added a commit
to skuruppu/nodejs-spanner
that referenced
this pull request
Aug 12, 2020
To fix recent protobuf errors based on googleapis/nodejs-pubsub#1085.
skuruppu
added a commit
to skuruppu/nodejs-spanner
that referenced
this pull request
Aug 12, 2020
To fix recent protobuf errors based on googleapis/nodejs-pubsub#1085. Fixes googleapis#1209
skuruppu
added a commit
to googleapis/nodejs-spanner
that referenced
this pull request
Aug 12, 2020
To fix recent protobuf errors based on googleapis/nodejs-pubsub#1085. Fixes #1209
This was referenced Aug 18, 2020
gcf-owl-bot bot
added a commit
that referenced
this pull request
Jan 13, 2022
Source-Link: googleapis/synthtool@4dfd20a Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:2d850512335d7adca3a4b08e02f8e63192978aea88c042dacb3e382aa996ae7c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user has an old version of gax installed and then updates Pub/Sub (specifically 2.4.0 after a synthtool update), it will cause object resolution failures, and possibly other problems. This bumps the minimum gax version to the latest release to take care of that mismatch.
Fixes: #1082