fix: add option to disable emulator auth handling (temp fix) #1861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feywind
added
the
do not merge
product-auto-label
bot
added
size: s
src/pubsub.ts
Outdated
| @@ -70,6 +70,7 @@ export type Omit<T, K extends keyof T> = Pick<T, Exclude<keyof T, K>>; | |||
|
|
|||
| export interface ClientConfig extends gax.GrpcClientOptions { | |||
| apiEndpoint?: string; | |||
| useFakeCredentials?: boolean; | |||
There was a problem hiding this comment.
I added a comment on the bug, but we should seriously consider alternatives to just adding another property like this. If we do end up adding it, let's not call it "useFakeCredentials."
product-auto-label
bot
added
size: m
feywind
added
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
|
@kamalaboulhosn Mind taking another look at this and see if you're okay with what I changed? Unfortunately this is now blocking TPC updates. :\ |
hongalex
approved these changes
Feb 7, 2024
gcf-owl-bot
bot
removed
the
owlbot:run
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Feb 8, 2024
🤖 I have created a release *beep* *boop* --- ## [4.3.1](https://togithub.com/googleapis/nodejs-pubsub/compare/v4.3.0...v4.3.1) (2024-02-08) ### Bug Fixes * Add option to disable emulator auth handling (temp fix) ([#1861](https://togithub.com/googleapis/nodejs-pubsub/issues/1861)) ([761cdc8](https://togithub.com/googleapis/nodejs-pubsub/commit/761cdc898c69715e6775d2f5913ead1fca2def02)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add manual control via PubSub options for whether the library uses "emulator mode", aka setting up for insecure SSL credentials for testing. Also fixes the heuristic to work with TPC.