Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add documentation about defaults for publisher #384

Merged
merged 1 commit into from
Dec 4, 2018
Merged

docs: Add documentation about defaults for publisher #384

merged 1 commit into from
Dec 4, 2018

Conversation

crwilcox
Copy link
Contributor

@crwilcox crwilcox commented Dec 4, 2018

Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for discussion)

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 4, 2018
@JustinBeckwith JustinBeckwith merged commit 5a40b04 into master Dec 4, 2018
@crwilcox crwilcox deleted the defaults-documentation branch December 4, 2018 17:35
feywind pushed a commit to feywind/nodejs-pubsub that referenced this pull request Nov 12, 2024
@JustinBeckwith @jkwlui
chore: always nyc report before calling codecov (googleapis#384)
1f28095
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crwilcox @JustinBeckwith @googlebot