Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(subscription)!: decouple retainAckedMessages from messageRetentionDuration #625

Merged
merged 2 commits into from
May 23, 2019
Merged

Conversation

callmehiphop
Copy link
Contributor

@callmehiphop callmehiphop commented May 23, 2019

Fixes #623

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@callmehiphop callmehiphop requested review from sduskis and bcoe May 23, 2019 21:35
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 23, 2019
@codecov
Copy link

codecov bot commented May 23, 2019

Codecov Report

Merging #625 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #625      +/-   ##
==========================================
- Coverage   97.89%   97.89%   -0.01%     
==========================================
  Files          14       14              
  Lines         857      856       -1     
  Branches      178      178              
==========================================
- Hits          839      838       -1     
  Misses          2        2              
  Partials       16       16
Impacted Files Coverage Δ
src/subscription.ts 99.18% <ø> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2167536...cb5c16d. Read the comment docs.

@sduskis sduskis merged commit 3431e7c into googleapis:master May 23, 2019
This was referenced May 23, 2019
This was referenced Apr 29, 2020
@feywind feywind mentioned this pull request May 20, 2020
@release-please release-please bot mentioned this pull request May 20, 2020
feywind pushed a commit to feywind/nodejs-pubsub that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decouple retainAckedMessages and messageRetentionDuration
3 participants