Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

test: throw on deprecation #132

Merged
merged 7 commits into from
Sep 20, 2018
Merged

test: throw on deprecation #132

merged 7 commits into from
Sep 20, 2018

Conversation

JustinBeckwith
Copy link
Contributor

No description provided.

@ghost ghost assigned JustinBeckwith Aug 2, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 2, 2018
@stephenplusplus
Copy link
Contributor

The system test told us about this one:

  1) SpeechSmokeTest v1p1beta1
       successfully makes a call to the service:
     DeprecationWarning: grpc.load: Use the @grpc/proto-loader module with grpc.loadPackageDefinition instead
      at GrpcClient.load (node_modules\google-gax\src\grpc.ts:224:27)
      at new OperationsClientBuilder (node_modules\google-gax\src\operations_client.ts:440:38)
      at new lro (node_modules\google-gax\src\index.ts:58:10)
      at new SpeechClient (src\v1p1beta1\speech_client.js:122:29)
      at Context.done (system-test\speech_smoke_test_v1p1beta1.js:21:18)

@JustinBeckwith
Copy link
Contributor Author

Ahh, then over to @alexander-fenster with this one since it's related to gax.

@ghost ghost assigned JustinBeckwith Aug 27, 2018
@StatusQuo
Copy link

Is there a chance to get this fix into the next version? :)

@codecov
Copy link

codecov bot commented Sep 20, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@1f867e4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #132   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?      2           
  Lines             ?     37           
  Branches          ?      0           
=======================================
  Hits              ?     37           
  Misses            ?      0           
  Partials          ?      0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f867e4...ded76a0. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit 2ba4b67 into master Sep 20, 2018
@jmdobry jmdobry deleted the throwdown branch October 16, 2018 19:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants