Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

docs(samples): convert samples tests to use mocha #221

Merged
merged 2 commits into from
Nov 17, 2018

Conversation

vijay-qlogic
Copy link
Contributor

Fixes nodejs-speeech: Convert all sample tests to mocha (it's a good idea to open an issue first for discussion)

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 28, 2018
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 28, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 28, 2018
@JustinBeckwith
Copy link
Contributor

Just a reminder to come back around and investigate the test failures :)

@vijay-qlogic
Copy link
Contributor Author

Yes, I'm looking into it.. Facing some challenges to resolve the issues here.

@JustinBeckwith
Copy link
Contributor

Coo. Let me know if I can help!

@codecov
Copy link

codecov bot commented Nov 6, 2018

Codecov Report

Merging #221 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #221   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          35     35           
=====================================
  Hits           35     35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b61174...3f21373. Read the comment docs.

@vijay-qlogic
Copy link
Contributor Author

One test "should run sync recognize with enhanced model"
in file "samples/system-test/recognize.test.js" on line no.129 is failing.

To fix that we need to enable "data logging" for "Cloud Speech API" in our project "Grass Clump 479"

Here is link to enable that Enable data logging

I do not have enough permissions to do so

@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 12, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 12, 2018
@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 16, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 16, 2018
@JustinBeckwith
Copy link
Contributor

👋 the test failure looks unrelated to that though:

 1) BetaFeatures
       should run speech diarization on a local file:
      AssertionError [ERR_ASSERTION]: false == true
      + expected - actual
      -false
      +true
      at Context.it (system-test/betaFeatures.test.js:58:12)
      at <anonymous>
      at process._tickCallback (internal/process/next_tick.js:188:7)

@JustinBeckwith JustinBeckwith merged commit 877d450 into googleapis:master Nov 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants