fix: Handle unhandled error in startResumableUpload_ (#2495)

* Added error handling using `stream.destroy`
googleapis · Jul 9, 2024 · d5257ba · d5257ba
1 parent 013a5a4
commit d5257ba
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 3 deletions.
diff --git a/src/file.ts b/src/file.ts
@@ -4141,8 +4141,7 @@ class File extends ServiceObject<File, FileMetadata> {
     ) {
       retryOptions.autoRetry = false;
     }
-
-    const uploadStream = resumableUpload.upload({
+    const cfg = {
       authClient: this.storage.authClient,
       apiEndpoint: this.storage.apiEndpoint,
       bucket: this.bucket.name,
@@ -4168,7 +4167,17 @@ class File extends ServiceObject<File, FileMetadata> {
       highWaterMark: options?.highWaterMark,
       universeDomain: this.bucket.storage.universeDomain,
       [GCCL_GCS_CMD_KEY]: options[GCCL_GCS_CMD_KEY],
-    });
+    };
+
+    let uploadStream: resumableUpload.Upload;
+
+    try {
+      uploadStream = resumableUpload.upload(cfg);
+    } catch (error) {
+      dup.destroy(error as Error);
+      this.storage.retryOptions.autoRetry = this.instanceRetryValue;
+      return;
+    }
 
     uploadStream
       .on('response', resp => {

diff --git a/test/file.ts b/test/file.ts
@@ -1991,6 +1991,25 @@ describe('File', () => {
       writable.write('data');
     });
 
+    it('should emit RangeError', done => {
+      const error = new RangeError(
+        'Cannot provide an `offset` without providing a `uri`'
+      );
+
+      const opitons = {
+        offset: 1,
+        isPartialUpload: true,
+      };
+      const writable = file.createWriteStream(opitons);
+
+      writable.on('error', (err: RangeError) => {
+        assert.deepEqual(err, error);
+        done();
+      });
+
+      writable.write('data');
+    });
+
     it('should emit progress via resumable upload', done => {
       const progress = {};