Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #566
To quickly sum up the issue discovered in #566, this works:
But as soon as it's a public file, it doesn't work:
I believe what happens when the file is flipped to a public object, we then have to worry about caching. When you update the file, the upstream API's
generation
property is updated as well for the Object record.So far, I've found three solutions:
Cache-Control: no-store
)Cache-Control: no-transform
on the file's metadatageneration
in the queryI went with the first, as it seems the least error-prone.