Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove dependency on pkg_resources, moving to implicit namespaces #160

Closed
wants to merge 1 commit into from

Conversation

JordiSalaJuarez
Copy link

pkg_resources.declare_namespace is deprecated, going for the native/implicit namespaces (PEP 420) is a much better option according to setuptools

Fixes issue #140

@JordiSalaJuarez JordiSalaJuarez requested a review from a team as a code owner May 3, 2023 08:37
@google-cla
Copy link

google-cla bot commented May 3, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented May 3, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label May 3, 2023
pkg_resources.declare_namespace is deprecated, going for the
native/implicit namespaces (PEP 420) is a much better option
@aqeelat
Copy link

aqeelat commented Jul 18, 2023

@clundin25 can we do the same thing we did in googleapis/google-auth-library-python#1205 here?

@clundin25
Copy link

@parthea PTAL

@aqeelat
Copy link

aqeelat commented Aug 1, 2023

@parthea @clundin25 any updates?

Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make a change similar to the one in googleapis/google-auth-library-python#1205

@parthea
Copy link
Contributor

parthea commented Nov 30, 2023

Fixed via #187

@parthea parthea closed this Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants