Skip to content

Conversation

arwas11
Copy link
Contributor

@arwas11 arwas11 commented May 5, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
    • screen/9c8bfeRerKkCt3h
    • screen/4B6ZsSVYaDR3o3c
    • screen/7FdJPXVpGNC2z7N
      Fixes #412723079 🦕

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. labels May 5, 2025
@arwas11 arwas11 marked this pull request as ready for review May 5, 2025 18:53
@arwas11 arwas11 requested review from a team as code owners May 5, 2025 18:53
@arwas11 arwas11 requested review from rsamborski and shuoweil May 5, 2025 18:53
@arwas11 arwas11 requested review from tswast and removed request for rsamborski May 5, 2025 18:53
@arwas11
Copy link
Contributor Author

arwas11 commented May 5, 2025

Unrelated e2e failure:

=========================== short test summary info ============================
FAILED tests/system/small/test_dataframe.py::test_series_binop_axis_index[le]
FAILED tests/system/small/test_dataframe.py::test_join_param_on[inner] - goog...

@arwas11 arwas11 enabled auto-merge (squash) May 5, 2025 19:55
@arwas11 arwas11 merged commit 99f45dd into main May 6, 2025
19 of 24 checks passed
@arwas11 arwas11 deleted the b412723079-fix-kmean-spacing branch May 6, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants