feat: Hybrid engine local join support #1900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
TrevorBergeron
force-pushed
the
engines_join
branch
from
49aef79 to
e5a8866
Compare
chelsea-lin
reviewed
Jul 11, 2025
| left_on = [] | ||
| right_on = [] | ||
| for left_ex, right_ex in node.conditions: | ||
| left_ex, right_ex = lowering._coerce_comparables(left_ex, right_ex) |
There was a problem hiding this comment.
Does polars treat NULL as different each other (similar to pandas or BQ)? I am wondering if Polars needs a _join_condition like compiler too?
There was a problem hiding this comment.
Polars df.join actually has a very helpful join_nulls (nulls_equal in more recent versions) argument that does exactly what we need
chelsea-lin
approved these changes
Jul 11, 2025
TrevorBergeron
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕