Skip to content

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Oct 1, 2025

Also fixes type errors identified when updating notebooks.

There is not really an efficient way for users to avoid this warning besides filtering it out. If folks have already opted-in to partial ordering mode, they have accepted the possibility of non-determinism relating to ordering. As such, I think it does more harm than good. Instead, I mailed internal cl/813806540 to document this possibility of unstable results.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes for email thread "Re: AmbiguousWindowWarning im Partial mode"
🦕

Also fixes type errors identified when updating notebooks.
@tswast tswast requested review from a team as code owners October 1, 2025 17:18
@tswast tswast requested a review from shuoweil October 1, 2025 17:18
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Oct 1, 2025
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Oct 1, 2025
@tswast tswast removed the request for review from shuoweil October 1, 2025 17:19
@tswast tswast merged commit 4607f86 into main Oct 2, 2025
24 of 25 checks passed
@tswast tswast deleted the tswast-AmbiguousWindowWarning branch October 2, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xl Pull request size is extra large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants