Skip to content

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Sep 21, 2023

Change-Id: Ib575e2c2b07f819d1dc499a271fea91107fbb8b4

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes header skipping logic in the read_csv. Current logic either does not skip the header, or when it does, it skips one additional row than asked for.

Change-Id: Ib575e2c2b07f819d1dc499a271fea91107fbb8b4
@shobsi shobsi requested review from a team as code owners September 21, 2023 22:18
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Sep 21, 2023
@shobsi shobsi merged commit d56258c into main Sep 26, 2023
@shobsi shobsi deleted the shobs-read-csv-skip-header branch September 26, 2023 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants