Skip to content

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented May 1, 2024

Fixes internal issue 339430305

test: refactor read_gbq / read_gbq_table tests to test with all parameters combined
refactor: move query generation code to BigQuery I/O module

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium. and removed size: s Pull request size is small. labels May 1, 2024
@tswast tswast force-pushed the b338111344-fix-index_col-read_gbq_table-to_query branch from 85f87de to 20e62b8 Compare May 8, 2024 15:57
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels May 8, 2024
@tswast tswast marked this pull request as ready for review May 8, 2024 15:58
@tswast tswast requested review from a team as code owners May 8, 2024 15:58
@tswast tswast requested a review from GarrettWu May 8, 2024 15:58
…ead_gbq_table`

Fixes internal issue 339430305

test: refactor `read_gbq` / `read_gbq_table` tests to test with all parameters combined
refactor: move query generation code to BigQuery I/O module
@tswast tswast force-pushed the b338111344-fix-index_col-read_gbq_table-to_query branch from 20e62b8 to 584bc93 Compare May 8, 2024 16:11
@tswast
Copy link
Collaborator Author

tswast commented May 8, 2024

test_read_gbq_start_sets_session_location[read_gbq_query-on-sql] looks like a real failure. I'll investigate.

@tswast tswast enabled auto-merge (squash) May 8, 2024 21:46
@tswast tswast merged commit e084e54 into main May 8, 2024
@tswast tswast deleted the b338111344-fix-index_col-read_gbq_table-to_query branch May 8, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants