Skip to content

Conversation

ashleyxuu
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal #338873779 🦕

@ashleyxuu ashleyxuu requested a review from tswast May 8, 2024 17:13
@ashleyxuu ashleyxuu requested review from a team as code owners May 8, 2024 17:13
@ashleyxuu ashleyxuu requested a review from engelke May 8, 2024 17:13
Copy link

snippet-bot bot commented May 8, 2024

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. labels May 8, 2024
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few nitpicks.

Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tswast
Copy link
Collaborator

tswast commented May 9, 2024

I've mailed internal CL 632203837 to address the permissions error in the remote functions sample.

@ashleyxuu ashleyxuu added the automerge Merge the pull request once unit tests and other checks pass. label May 9, 2024
@ashleyxuu ashleyxuu merged commit 93416ed into main May 9, 2024
@ashleyxuu ashleyxuu deleted the ashleyxu-text-generate-snippets branch May 9, 2024 20:20
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 9, 2024
@ashleyxuu ashleyxuu changed the title docs: add code snippets for llm text generatiion docs: add code snippets for llm text generation May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants