Skip to content

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented May 29, 2024

BEGIN_COMMIT_OVERRIDE
fix: set bpd.remote_function()s input_types and output_types default to None to allow omitting them when type annotations are present (#729)
END_COMMIT_OVERRIDE

Follow-up to #717 which made these parameters optional but forgot to add default values.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 343447415
🦕

…ault to `None` to allow omitting them when type annotations are present
@tswast tswast requested review from a team as code owners May 29, 2024 16:00
@tswast tswast requested a review from junyazhang May 29, 2024 16:00
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels May 29, 2024
)
import datetime

import bigframes_vendored.constants
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to avoid circular dependencies since unfortunately import bigframes.constants implies import bigframes; import bigframes.constants.

@tswast tswast enabled auto-merge (squash) May 29, 2024 16:08
@tswast tswast merged commit 0e25a3b into main May 29, 2024
@tswast tswast deleted the b343447415-remote_function-type-annotations branch May 29, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants