perf: Optimize dataframe-series alignment on axis=1 #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
TrevorBergeron
force-pushed
the
align_df_series
branch
from
6564d12
to
1306281
Compare
chelsea-lin
reviewed
May 30, 2024
bigframes/session/__init__.py
Outdated
| local_block = blocks.Block.from_local(pandas_dataframe, self) | ||
| assert local_block._transpose_cache is not None | ||
| inline_df = dataframe.DataFrame(local_block) | ||
| ### REMOVE BEFORE SUBMIT!!!!! |
There was a problem hiding this comment.
The presubmit tests are still failing on this assertion. Could you please take another look?
To help identify any problems in coming changes (from any other devs), should we consider enabling this check when we run our pytest?
There was a problem hiding this comment.
this assertion was just to help me debug specific tests cases, and not something that should be applied generally, removed from new revision
chelsea-lin
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕