Skip to content

Conversation

TrevorBergeron
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jul 4, 2024
@TrevorBergeron TrevorBergeron force-pushed the better_implicit_joiner branch from 93f1733 to fc17398 Compare July 4, 2024 02:28
@TrevorBergeron TrevorBergeron marked this pull request as ready for review July 4, 2024 02:28
@TrevorBergeron TrevorBergeron requested review from a team as code owners July 4, 2024 02:28
@TrevorBergeron TrevorBergeron requested a review from Genesis929 July 4, 2024 02:28
import bigframes._config.display_options as display_options
import bigframes.core.indexes as bf_indexes
import bigframes.dataframe as dataframe
import bigframes.pandas
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems import not used and maybe duplicated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed in new revision

@TrevorBergeron TrevorBergeron merged commit 0d24f73 into main Jul 11, 2024
@TrevorBergeron TrevorBergeron deleted the better_implicit_joiner branch July 11, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants