Skip to content

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Aug 21, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards internal code change 662899733 🦕

@tswast tswast requested review from a team as code owners August 21, 2024 15:29
Copy link

snippet-bot bot commented Aug 21, 2024

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. labels Aug 21, 2024
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Aug 21, 2024
@tswast tswast requested a review from chelsea-lin October 25, 2024 17:06
@tswast tswast merged commit f80d705 into main Nov 25, 2024
18 of 23 checks passed
@tswast tswast deleted the tswast-ordering-mode-partial-sample branch November 25, 2024 19:32
@tswast
Copy link
Collaborator Author

tswast commented Nov 25, 2024

Oops. I merged too soon. #1173 to fix the failing Samples tests.

Since it was only remote function and llm that were failures, I (incorrectly) assumed those were flakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants