Skip to content

fix: unordered mode errors in ml train_test_split #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 28, 2024
Merged

fix: unordered mode errors in ml train_test_split #925

merged 4 commits into from
Aug 28, 2024

Conversation

GarrettWu
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #359602325 🦕

@GarrettWu GarrettWu self-assigned this Aug 23, 2024
@GarrettWu GarrettWu requested review from a team as code owners August 23, 2024 21:57
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Aug 23, 2024
@GarrettWu GarrettWu enabled auto-merge (squash) August 28, 2024 17:26
@GarrettWu GarrettWu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 28, 2024
@bigframes-bot bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 28, 2024
@GarrettWu GarrettWu merged commit 85d7c21 into main Aug 28, 2024
20 of 23 checks passed
@GarrettWu GarrettWu deleted the garrettwu-split branch August 28, 2024 21:59
@release-please release-please bot mentioned this pull request Aug 28, 2024
Merged
arwas11 pushed a commit that referenced this pull request Sep 3, 2024
@GarrettWu @arwas11
fix: unordered mode errors in ml train_test_split (#925)
fc595d3 
* fix: unordered errors in ml train_test_split

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrevorBergeron TrevorBergeron TrevorBergeron approved these changes

@shobsi shobsi shobsi approved these changes

Assignees

@GarrettWu GarrettWu

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GarrettWu @TrevorBergeron @shobsi @bigframes-bot