Skip to content

fix: change the invalid url in docs #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 7, 2023
Merged

fix: change the invalid url in docs #93

merged 2 commits into from
Oct 7, 2023

Conversation

ashleyxuu
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@ashleyxuu ashleyxuu requested review from a team as code owners October 6, 2023 23:29
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 6, 2023
@ashleyxuu ashleyxuu self-assigned this Oct 6, 2023
dandhlee
dandhlee reviewed Oct 6, 2023
View reviewed changes
dandhlee
dandhlee approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the super quick fix!

@ashleyxuu ashleyxuu merged commit 969800d into main Oct 7, 2023
@ashleyxuu ashleyxuu deleted the b303733839-fix-internal-url branch October 7, 2023 02:41
@release-please release-please bot mentioned this pull request Oct 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GarrettWu GarrettWu GarrettWu approved these changes

@dandhlee dandhlee dandhlee approved these changes

Assignees

@ashleyxuu ashleyxuu

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashleyxuu @GarrettWu @dandhlee