Skip to content

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Sep 3, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 364164991 🦕

@shobsi shobsi requested review from a team as code owners September 3, 2024 23:32
@shobsi shobsi requested a review from sycai September 3, 2024 23:32
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Sep 3, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Sep 3, 2024
@shobsi shobsi merged commit c750be6 into main Sep 6, 2024
23 checks passed
@shobsi shobsi deleted the shobs-read-gbq-function-multiple-params branch September 6, 2024 06:22
arwas11 pushed a commit that referenced this pull request Sep 9, 2024
* fix: make `read_gbq_function` work for multi-param functions

* fix hyperlink

* specify hyperlink differently

* make hyperlink markdown format
tswast added a commit that referenced this pull request Oct 3, 2024
* docs: add docstring return type section to BigQueryOptions class

* docs: add docstring return type section to BigQueryOptions class

* docs: add docstrings to SamplingOptions class

* feat: add Gemini 1.5 stable models support (#945)

* feat: add Gemini 1.5 stable models support

* add to loader

* refactor: Simplify projection nodes (#961)

* docs: add docstring returns section to Options (#937)

* chore: drop unused columns at is_monotonic methods (#912)

* chore: drop unused columns at is_monotonic methods

* fixing mypy

* test: retry streaming tests to accommodate flakiness (#956)

* test: retry streaming tests to accommodate flakiness

* reduce delay, increase retries

* fix: make `read_gbq_function` work for multi-param functions (#947)

* fix: make `read_gbq_function` work for multi-param functions

* fix hyperlink

* specify hyperlink differently

* make hyperlink markdown format

* fix: support `read_gbq_function` for axis=1 application (#950)

* fix: support `read_gbq_function` for axis=1 application

* remove stray newline

* Update bigframes/session/__init__.py

* remove first person reference in the doc

* use correct product name

---------

Co-authored-by: Tim Sweña (Swast) <swast@google.com>

* docs: update title of pypi notebook example to reflect use of the PyPI public dataset (#952)

In response to feedback on internal change 662899733.

* docs: add docstrings to SamplingOptions class

---------

Co-authored-by: Garrett Wu <6505921+GarrettWu@users.noreply.github.com>
Co-authored-by: TrevorBergeron <tbergeron@google.com>
Co-authored-by: Chelsea Lin <124939984+chelsea-lin@users.noreply.github.com>
Co-authored-by: Shobhit Singh <shobs@google.com>
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants