Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added text_annotation to vision conversion #114

Merged
merged 5 commits into from
May 31, 2023
Merged

feat: added text_annotation to vision conversion #114

merged 5 commits into from
May 31, 2023

Conversation

galz10
Copy link
Collaborator

@galz10 galz10 commented May 22, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@galz10 galz10 requested a review from holtskinner May 22, 2023 18:36
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label May 22, 2023
@galz10 galz10 marked this pull request as ready for review May 22, 2023 18:36
@galz10 galz10 requested review from a team as code owners May 22, 2023 18:36
@holtskinner holtskinner added the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2023
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: m Pull request size is medium. labels May 30, 2023
@galz10 galz10 requested a review from xixiong May 30, 2023 22:49
@galz10 galz10 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 31, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 31, 2023
@galz10 galz10 merged commit 27196bb into googleapis:main May 31, 2023
@galz10 galz10 deleted the vision-update branch May 31, 2023 16:52
@release-please release-please bot mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xixiong xixiong xixiong approved these changes

@holtskinner holtskinner holtskinner approved these changes

Assignees
No one assigned
Labels
size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@galz10 @xixiong @holtskinner