Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

feat: bump release level to production/stable #60

Merged
merged 2 commits into from
Sep 29, 2021
Merged

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Jul 31, 2021

Fixes #59 🦕

Release-As: 1.0.0

@parthea parthea requested a review from a team as a code owner July 31, 2021 10:42
@product-auto-label product-auto-label bot added the api: gkehub Issues related to the googleapis/python-gke-hub API. label Jul 31, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 31, 2021
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jul 31, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 31, 2021
@parthea parthea added do not merge Indicates a pull request not ready for merge, due to either quality or timing. kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jul 31, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 2, 2021
@parthea
Copy link
Contributor Author

parthea commented Aug 16, 2021

Wait until 28 days after the release where #63 is solved

@tseaver
Copy link

tseaver commented Aug 16, 2021

@parthea

Wait until 28 days after the release where #63 is solved

I presume this is after #64 merges. Is 28 days the standard interval for beta -> ga? Or is that because #64 contains quasi-breaking changes (moving imports)?

@parthea
Copy link
Contributor Author

parthea commented Aug 17, 2021

I presume this is after #64 merges.

Correct. The 28 day timer will start when we publish the release after #64 is merged.

Is 28 days the standard interval for beta -> ga?

Correct. It is standard interval for beta->ga where we wait 28 days after releasing a client which includes a stable endpoint.

Or is that because #64 contains quasi-breaking changes (moving imports)?

Correct, and I also think it's a good idea to reset the 28 day timer since I don't think we've released a version of this library which included a working v1 client. The last release had a broken v1 client.

@parthea
Copy link
Contributor Author

parthea commented Aug 27, 2021

Wait until September 20, 2021.

@parthea parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 27, 2021
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Sep 27, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 27, 2021
@parthea parthea added the automerge Merge the pull request once unit tests and other checks pass. label Sep 29, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 5877ee6 into main Sep 29, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the ga-release branch September 29, 2021 23:32
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 29, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: gkehub Issues related to the googleapis/python-gke-hub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release as GA
4 participants