Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pass custom Client object to dbapi #911

Merged
merged 5 commits into from
Mar 28, 2023
Merged

feat: pass custom Client object to dbapi #911

merged 5 commits into from
Mar 28, 2023

Conversation

asthamohta
Copy link
Contributor

No description provided.

@asthamohta asthamohta requested review from a team as code owners March 14, 2023 10:58
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/python-spanner API. labels Mar 14, 2023
@asthamohta asthamohta enabled auto-merge (squash) March 20, 2023 05:16
rajatbhatta
rajatbhatta approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@rajatbhatta rajatbhatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a method doc fix. Apart from it, LGTM.

google/cloud/spanner_dbapi/connection.py Outdated Show resolved Hide resolved
@asthamohta @rajatbhatta
Update google/cloud/spanner_dbapi/connection.py
624b948 
Co-authored-by: Rajat Bhatta <93644539+rajatbhatta@users.noreply.github.com>
@asthamohta asthamohta merged commit 52b1a0a into googleapis:main Mar 28, 2023
@release-please release-please bot mentioned this pull request Mar 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajatbhatta rajatbhatta rajatbhatta approved these changes

@surbhigarg92 surbhigarg92 surbhigarg92 approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asthamohta @surbhigarg92 @rajatbhatta