Skip to content

feat(zb-experimental): Add support for closing MRD #1554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 83 commits into from
Sep 30, 2025
Merged

feat(zb-experimental): Add support for closing MRD #1554

merged 83 commits into from
Sep 30, 2025
+175 −40

Conversation

chandra-siri
Copy link
Contributor

@chandra-siri chandra-siri commented Sep 25, 2025 •
edited
Loading

  • add is_stream_open and check it's value before doing any of the following operation. open , close , send ,recv
  • Instantiate socket_like_rpc inside open, so that it is a new object every time we open.
    • Otherwise, consider this scenario where a user is opening after closing then initial_request would be None because close sets it to None.

@chandra-siri
add AsyncAbstractObjectStream
21e66a3 
this will be the parent class for AsyncReadObjectStream and AsyncWriteObjectStream
@chandra-siri
keep _AsyncAbstractObjectStream private
39503f4
@chandra-siri
Add _AsyncReadObjectStream and it's stubs
a161fd0
@chandra-siri
complete __init__ for read_obj_str
dd862a2
@chandra-siri
remove unuseful comments
aaabfd7
@chandra-siri
add methods open close send recv
23eea96
@chandra-siri
change read_handle type from 'str' to 'bytes'
71a7a79
@chandra-siri
feat: add async_multi_range_downloader
827aec0
@chandra-siri
fix: read_ranges should have buffer as well
5be7469
@chandra-siri
rename MultiRangeDownloader to AsyncMultiRangeDownloader
b3ad551
@chandra-siri
feat: implement download_ranges method
a87f2be
@chandra-siri
add BytesIO in doc string
c2e3c7b
@chandra-siri
Merge branch 'main' of github.com:googleapis/python-storage into bidi…
3c0fd66 
…_reads_1_abs_obj_stream
@chandra-siri
fix doc strings, add licence and type hints
0810afc
@chandra-siri
Merge branch 'bidi_reads_1_abs_obj_stream' of github.com:googleapis/p…
d43d889 
…ython-storage into bidi_reads_2_read_obj_stream
@chandra-siri
pass abstract methods
a14bc68
@chandra-siri
Merge branch 'bidi_reads_1_abs_obj_stream' of github.com:googleapis/p…
fbacbb4 
…ython-storage into bidi_reads_2_read_obj_stream
@chandra-siri
Merge branch 'bidi_reads_2_read_obj_stream' of github.com:googleapis/…
fd37489 
…python-storage into bidi_reads_3_read_obj_stream
@chandra-siri
add handle param
635ad07
@chandra-siri
include handle in tests
ba453d4
@chandra-siri
remove unit tests for abstract class
800c6df
@chandra-siri
Merge branch 'bidi_reads_1_abs_obj_stream' of github.com:googleapis/p…
8b40812 
…ython-storage into bidi_reads_2_read_obj_stream
@chandra-siri
edit doc string for _AsyncReadObjectStream
18529ad
@chandra-siri
Merge branch 'bidi_reads_2_read_obj_stream' of github.com:googleapis/…
df2532e 
…python-storage into bidi_reads_3_read_obj_stream
@chandra-siri
refactor unit tests for async_read_object_stream
b4da1ac
@chandra-siri
bucket_name and object_name cannot be NONE
6dec6c6
@chandra-siri
Merge branch 'bidi_reads_1_abs_obj_stream' of github.com:googleapis/p…
90a65f6 
…ython-storage into bidi_reads_2_read_obj_stream
@chandra-siri
bucket_name and object_name cannot be None
a154905
@chandra-siri
Merge branch 'bidi_reads_2_read_obj_stream' of github.com:googleapis/…
d69cd63 
…python-storage into bidi_reads_3_read_obj_stream
@chandra-siri
Merge branch 'bidi_reads_3_read_obj_stream' of github.com:googleapis/…
20afca4 
…python-storage into bidi_reads_4_read_obj_stream
@chandra-siri chandra-siri requested review from a team as code owners September 25, 2025 17:36
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/python-storage API. labels Sep 25, 2025
Base automatically changed from bidi_reads_6_read_obj_stream to main September 29, 2025 07:54
Pulkit0110
Pulkit0110 requested changes Sep 30, 2025
View reviewed changes
Pulkit0110
Pulkit0110 previously approved these changes Sep 30, 2025
View reviewed changes
@chandra-siri chandra-siri merged commit 9c8856a into main Sep 30, 2025
15 checks passed
@chandra-siri chandra-siri deleted the bidi_reads_7 branch September 30, 2025 09:37
@release-please release-please bot mentioned this pull request Sep 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pulkit0110 Pulkit0110 Pulkit0110 approved these changes

Assignees

@Pulkit0110 Pulkit0110

Labels
api: storage Issues related to the googleapis/python-storage API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chandra-siri @Pulkit0110