Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retry client side requests timeout #727

Merged
merged 2 commits into from
Mar 10, 2022
Merged

Conversation

cojenco
Copy link
Contributor

@cojenco cojenco commented Mar 10, 2022

Add client-side requests.exceptions.Timeout to _RETRYABLE_TYPES
Test automatically covered here

Fixes #726 🦕

@cojenco cojenco requested review from a team as code owners March 10, 2022 01:02
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Mar 10, 2022
mlazowik added a commit to qedsoftware/django-storages that referenced this pull request Mar 10, 2022
Revert this comment after a version of `google-cloud-storage` with
googleapis/python-storage#727 gets released and
ScanForm is updated to use it.
mlazowik added a commit to qedsoftware/django-storages that referenced this pull request Mar 10, 2022
Revert this comment after a version of `google-cloud-storage` with
googleapis/python-storage#727 gets released and
ScanForm is updated to use it.
mlazowik added a commit to qedsoftware/django-storages that referenced this pull request Mar 10, 2022
Revert this comment after a version of `google-cloud-storage` with
googleapis/python-storage#727 gets released and
ScanForm is updated to use it.
mlazowik added a commit to qedsoftware/django-storages that referenced this pull request Mar 10, 2022
Revert this comment after a version of `google-cloud-storage` with
googleapis/python-storage#727 gets released and
ScanForm is updated to use it.
mlazowik added a commit to qedsoftware/django-storages that referenced this pull request Mar 10, 2022
Revert this comment after a version of `google-cloud-storage` with
googleapis/python-storage#727 gets released and
ScanForm is updated to use it.
mlazowik added a commit to qedsoftware/django-storages that referenced this pull request Mar 10, 2022
* [gcloud] Retry on connection/read timeout

Revert this comment after a version of `google-cloud-storage` with
googleapis/python-storage#727 gets released and
ScanForm is updated to use it.

* [tests/gcloud] Add retry to expected params
@cojenco cojenco merged commit e0b3b35 into googleapis:main Mar 10, 2022
@cojenco cojenco deleted the timeout726 branch November 16, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/python-storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requests are not retried on connect/read timeouts
2 participants