-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: retry client side requests timeout #727
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
Issues related to the googleapis/python-storage API.
label
Mar 10, 2022
parthea
approved these changes
Mar 10, 2022
mlazowik
added a commit
to qedsoftware/django-storages
that referenced
this pull request
Mar 10, 2022
Revert this comment after a version of `google-cloud-storage` with googleapis/python-storage#727 gets released and ScanForm is updated to use it.
mlazowik
added a commit
to qedsoftware/django-storages
that referenced
this pull request
Mar 10, 2022
Revert this comment after a version of `google-cloud-storage` with googleapis/python-storage#727 gets released and ScanForm is updated to use it.
mlazowik
added a commit
to qedsoftware/django-storages
that referenced
this pull request
Mar 10, 2022
Revert this comment after a version of `google-cloud-storage` with googleapis/python-storage#727 gets released and ScanForm is updated to use it.
mlazowik
added a commit
to qedsoftware/django-storages
that referenced
this pull request
Mar 10, 2022
Revert this comment after a version of `google-cloud-storage` with googleapis/python-storage#727 gets released and ScanForm is updated to use it.
mlazowik
added a commit
to qedsoftware/django-storages
that referenced
this pull request
Mar 10, 2022
Revert this comment after a version of `google-cloud-storage` with googleapis/python-storage#727 gets released and ScanForm is updated to use it.
mlazowik
added a commit
to qedsoftware/django-storages
that referenced
this pull request
Mar 10, 2022
* [gcloud] Retry on connection/read timeout Revert this comment after a version of `google-cloud-storage` with googleapis/python-storage#727 gets released and ScanForm is updated to use it. * [tests/gcloud] Add retry to expected params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add client-side
requests.exceptions.Timeout
to_RETRYABLE_TYPES
Test automatically covered here
Fixes #726 🦕